linux-kernel - Re: [PATCH v8 04/22] s390/zcrypt: Integrate ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <74375e1e-b5c2-705c-e618-9b89889f61cf@linux.ibm.com>
Date:   Thu, 9 Aug 2018 12:55:07 -0400
From:   Tony Krowiak <akrowiak@...ux.ibm.com>
To:     Heiko Carstens <heiko.carstens@...ibm.com>
Cc:     Cornelia Huck <cohuck@...hat.com>,
        Tony Krowiak <akrowiak@...ux.vnet.ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, freude@...ibm.com, schwidefsky@...ibm.com,
        borntraeger@...ibm.com, kwankhede@...dia.com,
        bjsdjshi@...ux.vnet.ibm.com, pbonzini@...hat.com,
        alex.williamson@...hat.com, pmorel@...ux.vnet.ibm.com,
        alifm@...ux.vnet.ibm.com, mjrosato@...ux.vnet.ibm.com,
        jjherne@...ux.vnet.ibm.com, thuth@...hat.com,
        pasic@...ux.vnet.ibm.com, berrange@...hat.com,
        fiuczy@...ux.vnet.ibm.com, buendgen@...ibm.com,
        frankja@...ux.ibm.com
Subject: Re: [PATCH v8 04/22] s390/zcrypt: Integrate ap_asm.h into
 include/asm/ap.h.

On 08/09/2018 11:43 AM, Heiko Carstens wrote:
> On Thu, Aug 09, 2018 at 11:18:05AM -0400, Tony Krowiak wrote:
>> On 08/09/2018 05:06 AM, Cornelia Huck wrote:
>>> On Wed,  8 Aug 2018 10:44:14 -0400
>>> Tony Krowiak <akrowiak@...ux.vnet.ibm.com> wrote:
>>>
>>>> From: Harald Freudenberger <freude@...ibm.com>
>>>>
>>>> Move all the inline functions from the ap bus header
>>>> file ap_asm.h into the in-kernel api header file
>>>> arch/s390/include/asm/ap.h so that KVM can make use
>>>> of all the low level AP functions.
>>>>
>>>> Signed-off-by: Harald Freudenberger <freude@...ibm.com>
>>>> Signed-off-by: Christian Borntraeger <borntraeger@...ibm.com>
>>> You should add your own s-o-b if you are sending on patches written by
>>> others (even if it does not matter in the end, when they are merged
>>> through a different path anyway.)
>> That's rather ironic given I was told in an internal review that I should
>> not sign off on patches I did not write.
> Please point the one who said that to
> Documentation/process/submitting-patches.rst / Developer's Certificate of Origin
>
> You really should sign off patches you forward, even if you did not write
> them on your own.

Duly noted and I will do so on future posts. Thanks for the reference.