linux-kernel - Re: [PATCH] perf probe powerpc: Fix trace event post-processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180809174410.GD5395@kernel.org>
Date:   Thu, 9 Aug 2018 14:44:10 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
Cc:     Sandipan Das <sandipan@...ux.ibm.com>,
        aneesh.kumar@...ux.vnet.ibm.com, jolsa@...hat.com,
        linux-kernel@...r.kernel.org, ravi.bangoria@...ux.ibm.com
Subject: Re: [PATCH] perf probe powerpc: Fix trace event post-processing

Em Thu, Aug 09, 2018 at 09:56:24PM +0530, Naveen N. Rao escreveu:
> Sandipan Das wrote:
<SNIP>
> > This can be verified on a powerpc64le system as shown below.
<SNIP>
> > Before:
> >   # perf probe -v -a sys_open
<SNIP>
> >   # perf probe -v -a sys_open%return $retval
<SNIP>
> >   Failed to write event: Invalid argument
> >     Error: Failed to add events. Reason: Invalid argument (Code: -22)
> > After:
> >   # perf probe -v -a sys_open
<SNIP>
> >   Writing event: p:probe/sys_open _text+4276888
> >   Added new event:
> >     probe:sys_open       (on sys_open)
> >   ...
> > 
> >   # perf probe -v -a sys_open%return $retval
<SNIP>
> >   Writing event: r:probe/sys_open__return _text+4276888
> >   Added new event:
> >     probe:sys_open__return (on sys_open%return)
> > Fixes: 99e608b5954c ("perf probe ppc64le: Fix probe location when using DWARF")
> > Reported-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> > Signed-off-by: Sandipan Das <sandipan@...ux.ibm.com>
 
> Acked-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>

Thanks, applied!

Excellent commit log message, btw, keep it up.

- arnaldo