linux-kernel - Re: [PATCH v3 0/7] firmware: coreboot: Fix probe and simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180809180316.GD129285@ban.mtv.corp.google.com>
Date:   Thu, 9 Aug 2018 11:03:18 -0700
From:   Brian Norris <briannorris@...omium.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Wei-Ning Huang <wnhuang@...omium.org>,
        Julius Werner <jwerner@...omium.org>,
        Samuel Holland <samuel@...lland.org>
Subject: Re: [PATCH v3 0/7] firmware: coreboot: Fix probe and simplify code

Hi Stepehen,

On Thu, Aug 09, 2018 at 10:17:15AM -0700, Stephen Boyd wrote:
> This series reworks the coreboot firmware driver a bit to fix some bugs
> and then simplify the code by changing the design to get rid of the
> different platform drivers, remap memory with memremap(), and use devm
> to simplify error paths. There's some risk in changing to memremap() but
> I think that should work out alright. It will either return memory
> directly, or fallback to ioremap_cache() as has been done before.
> 
> Changes from v2:
>  * A bunch more patches
>  * Fix iounmap missing on error path
>  * Fix bus getting unregistered on driver unbind and never registered
>    again
>  * Request exclusive access to table region
>  * Pull out table signature check to driver probe
> 
> Changes from v1:
>  * Split out fixlet for DT based driver from platform driver change
> 
> Cc: Wei-Ning Huang <wnhuang@...omium.org>
> Cc: Julius Werner <jwerner@...omium.org>
> Cc: Brian Norris <briannorris@...omium.org>
> Cc: Samuel Holland <samuel@...lland.org>
> 
> Stephen Boyd (7):
>   firmware: coreboot: Let OF core populate platform device
>   firmware: coreboot: Unmap ioregion on failure
>   firmware: coreboot: Make bus registration symmetric
>   firmware: coreboot: Collapse platform drivers into bus core
>   firmware: coreboot: Remap RAM with memremap() instead of ioremap()
>   firmware: coreboot: Only populate devices in coreboot_table_init()
>   firmware: coreboot: Request table region for exclusive access

I gave patches 1 and 2 closer review (and individual replies); the
remaining patches look good to me too, so for the whole series:

Reviewed-by: Brian Norris <briannorris@...omium.org>

>  drivers/firmware/google/Kconfig               |  26 ++--
>  drivers/firmware/google/Makefile              |   2 -
>  drivers/firmware/google/coreboot_table-acpi.c |  88 ------------
>  drivers/firmware/google/coreboot_table-of.c   |  82 -----------
>  drivers/firmware/google/coreboot_table.c      | 135 +++++++++++++-----
>  drivers/firmware/google/coreboot_table.h      |   6 -
>  6 files changed, 107 insertions(+), 232 deletions(-)
>  delete mode 100644 drivers/firmware/google/coreboot_table-acpi.c
>  delete mode 100644 drivers/firmware/google/coreboot_table-of.c
> 
> -- 
> Sent by a computer through tubes
>