linux-kernel - Re: [PATCH 1/3] net:svc_rdma_transport: remove unneeded variable 'ret' in rdma_listen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180809200644.GN23873@fieldses.org>
Date:   Thu, 9 Aug 2018 16:06:44 -0400
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     Anna Schumaker <Anna.Schumaker@...app.com>
Cc:     zhong jiang <zhongjiang@...wei.com>, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] net:svc_rdma_transport: remove unneeded variable
 'ret' in rdma_listen_handler

On Tue, Aug 07, 2018 at 10:49:11AM -0400, Anna Schumaker wrote:
> (Adding Bruce since he takes nfs / sunrpc server patches)

Applied, thanks.--b.

> 
> On 08/07/2018 07:20 AM, zhong jiang wrote:
> > The ret is not modified after initalization, So just remove the variable
> > and return 0.
> > 
> > Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> > ---
> >  net/sunrpc/xprtrdma/svc_rdma_transport.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > index 547b2cd..2848caf 100644
> > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > @@ -296,7 +296,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
> >  			       struct rdma_cm_event *event)
> >  {
> >  	struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr;
> > -	int ret = 0;
> >  
> >  	trace_svcrdma_cm_event(event, sap);
> >  
> > @@ -315,7 +314,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
> >  		break;
> >  	}
> >  
> > -	return ret;
> > +	return 0;
> >  }
> >  
> >  static int rdma_cma_handler(struct rdma_cm_id *cma_id,
> >