linux-kernel - Re: [PATCH v8 1/4] PCI: Make specifying PCI devices in kernel parameters reusable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512aa96e-1c31-ecbd-88c7-a5e417d533ba@deltatee.com>
Date:   Thu, 9 Aug 2018 15:18:16 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-doc@...r.kernel.org, Stephen Bates <sbates@...thlin.com>,
        Christoph Hellwig <hch@....de>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Jérôme Glisse <jglisse@...hat.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Christian König <christian.koenig@....com>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v8 1/4] PCI: Make specifying PCI devices in kernel
 parameters reusable



On 09/08/18 03:15 PM, Bjorn Helgaas wrote:
>> @@ -2994,7 +2994,26 @@
>>  			See header of drivers/block/paride/pcd.c.
>>  			See also Documentation/blockdev/paride.txt.
>>  
>> -	pci=option[,option...]	[PCI] various PCI subsystem options:
>> +	pci=option[,option...]	[PCI] various PCI subsystem options.
>> +
>> +				Some options herein operate on a specific device
>> +				or a set of devices (<pci_dev>). These are
>> +				specified in one of the following formats:
>> +
>> +				[<domain>:]<bus>:<slot>.<func>
>> +				pci:<vendor>:<device>[:<subvendor>:<subdevice>]
>> +
>> +				Note: the first format specifies a PCI
>> +				bus/slot/function address which may change
> 
> Unless you object, I'm going to change "slot" references like this to
> "device" so they match "BDF" and the language in the spec, which uses
> "slot" to refer to a physical slot and "device" when referring to
> geographical device addresses.  I can do this when I apply these, so
> no need for you to repost them.

No objection. I never liked the "slot" reference but was trying to
remain consistent with what was there before. If I remember correctly
there's a bunch of places in the kernel that use slot as well.

Thanks,

Logan