linux-kernel - Re: a13c600e15 ("x86/mm/pti: Move user W+X check into .."): WARNING: CPU: 0 PID: 1 at arch/x86/mm/dump_pagetables.c:283 note

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180810083504.55pljlr733lctz5k@suse.de>
Date:   Fri, 10 Aug 2018 10:35:04 +0200
From:   Joerg Roedel <jroedel@...e.de>
To:     kernel test robot <lkp@...el.com>
Cc:     LKP <lkp@...org>, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: a13c600e15 ("x86/mm/pti: Move user W+X check into .."): WARNING:
 CPU: 0 PID: 1 at arch/x86/mm/dump_pagetables.c:283 note_page

On Fri, Aug 10, 2018 at 06:33:42AM +0800, kernel test robot wrote:
> commit a13c600e15de44ccf03df28d3311ef3cb754ed9b
> Author:     Joerg Roedel <jroedel@...e.de>
> AuthorDate: Wed Aug 8 13:16:40 2018 +0200
> Commit:     Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Thu Aug 9 20:42:07 2018 +0200
> 
>     x86/mm/pti: Move user W+X check into pti_finalize()

Okay, I found the problem and the diff below fixes it.

Ingo, Thomas, can you fold that diff into above commit or do you prefer
a separate patch?

Thanks and sorry for the hassle,


       Joerg

diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c
index 026a89aa16d7..d1435c78ae4f 100644
--- a/arch/x86/mm/pti.c
+++ b/arch/x86/mm/pti.c
@@ -629,5 +629,6 @@ void pti_finalize(void)
 	pti_clone_entry_text();
 	pti_clone_kernel_text();
 
-	debug_checkwx_user();
+	if (__supported_pte_mask & _PAGE_NX)
+		debug_checkwx_user();
 }