linux-kernel - Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC6rBsmkTSSg1RhWkpU-t+tQdyz7NKbfu96tX9BG1=LOGVg-Bw@mail.gmail.com>
Date:   Sat, 11 Aug 2018 00:25:39 +1000
From:   Rashmica Gupta <rashmica.g@...il.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, toshi.kani@....com,
        tglx@...utronix.de, bp@...e.de, brijesh.singh@....com,
        thomas.lendacky@....com, jglisse@...hat.com,
        gregkh@...uxfoundation.org, baiyaowei@...s.chinamobile.com,
        dan.j.williams@...el.com, iamjoonsoo.kim@....com,
        Vlastimil Babka <vbabka@...e.cz>, malat@...ian.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Oscar Salvador <osalvador@...hadventures.net>,
        yasu.isimatu@...il.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Mike Rapoport <rppt@...ux.vnet.ibm.com>
Subject: Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

On Fri, Aug 10, 2018 at 11:00 PM, Michal Hocko <mhocko@...nel.org> wrote:
> On Fri 10-08-18 16:55:40, Rashmica Gupta wrote:
> [...]
>> Most memory hotplug/hotremove seems to be block or section based, and
>> always adds and removes memory at the same place.
>
> Yes and that is hard wired to the memory hotplug code. It is not easy to
> make it work outside of section units restriction. So whatever your
> memtrace is doing and if it relies on subsection hotplug it cannot
> possibly work with the current code.
>
> I didn't get to review your patch but if it is only needed for an
> unmerged code I would rather incline to not merge it unless it is a
> clear win to the resource subsystem. A report from Oscar shows that this
> is not the case though.
>

Yup, makes sense. I'll work on it and see if I can not break things.

> --
> Michal Hocko
> SUSE Labs