linux-kernel - Re: [PATCH 02/16] staging: gasket: core: remove debug log that could crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CALTjKEN=jwaasgdb_GMd7i1mPowS16MKxUoBbpHV++RSCu0dfw@mail.gmail.com>
Date:   Fri, 10 Aug 2018 09:57:30 -0700
From:   Rob Springer <rspringer@...gle.com>
To:     toddpoynor@...il.com
Cc:     John Joseph <jnjoseph@...gle.com>, benchan@...omium.org,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Todd Poynor <toddpoynor@...gle.com>
Subject: Re: [PATCH 02/16] staging: gasket: core: remove debug log that could crash

Reviewed-by: Rob Springer <rspringer@...gle.com>

On Fri, Aug 10, 2018 at 9:56 AM Rob Springer <rspringer@...gle.com> wrote:
>
> Revewed-by: Rob Springer <rspringer@...gle.com>
>
> On Thu, Aug 9, 2018 at 8:21 PM Todd Poynor <toddpoynor@...il.com> wrote:
>>
>> From: Todd Poynor <toddpoynor@...gle.com>
>>
>> A debug log in gasket_alloc_dev() is issued regardless of whether the
>> device pointer used returned success or error.  The log isn't that
>> useful anyway, remove it.
>>
>> Signed-off-by: Todd Poynor <toddpoynor@...gle.com>
>> ---
>>  drivers/staging/gasket/gasket_core.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
>> index d12ab560411f7..37d14e30ffa21 100644
>> --- a/drivers/staging/gasket/gasket_core.c
>> +++ b/drivers/staging/gasket/gasket_core.c
>> @@ -234,8 +234,6 @@ static int gasket_alloc_dev(struct gasket_internal_desc *internal_desc,
>>         dev_info->device = device_create(internal_desc->class, parent,
>>                 dev_info->devt, gasket_dev, dev_info->name);
>>
>> -       dev_dbg(dev_info->device, "Gasket device allocated.\n");
>> -
>>         /* cdev has not yet been added; cdev_added is 0 */
>>         dev_info->gasket_dev_ptr = gasket_dev;
>>         /* ownership is all 0, indicating no owner or opens. */
>> --
>> 2.18.0.597.ga71716f1ad-goog
>>