| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACO55tv+QLcNRj7UDK=7NnoxTxpKHWd2GqU=Eftc-suhUn4J6A@mail.gmail.com>
Date: Fri, 10 Aug 2018 23:37:12 +0200
From: Karol Herbst <kherbst@...hat.com>
To: Lyude Paul <lyude@...hat.com>
Cc: nouveau <nouveau@...ts.freedesktop.org>,
David Airlie <airlied@...ux.ie>,
dri-devel <dri-devel@...ts.freedesktop.org>,
LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
Ben Skeggs <bskeggs@...hat.com>
Subject: Re: [Nouveau] [PATCH v5 08/13] drm/nouveau: Don't ignore
nouveau_do_suspend() ret value
Reviewed-by: Karol Herbst <kherbst@...hat.com>
On Tue, Aug 7, 2018 at 10:39 PM, Lyude Paul <lyude@...hat.com> wrote:
> Otherwise, how will we roll everything back?
>
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Cc: stable@...r.kernel.org
> Cc: Lukas Wunner <lukas@...ner.de>
> Cc: Karol Herbst <karolherbst@...il.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_drm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
> index db56e9b6b6af..f79b435368ec 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
> @@ -842,6 +842,9 @@ nouveau_pmops_runtime_suspend(struct device *dev)
> }
>
> ret = nouveau_do_suspend(drm_dev, true);
> + if (ret)
> + return ret;
> +
> nouveau_switcheroo_optimus_dsm();
> pci_save_state(pdev);
> pci_disable_device(pdev);
> --
> 2.17.1
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
Powered by blists - more mailing lists