lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Aug 2018 13:55:37 +0900 From: Namhyung Kim <namhyung@...nel.org> To: Benno Evers <bevers@...osphere.com> Cc: Krister Johansen <kjlx@...pleofstupid.com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org, kernel-team@....com Subject: Re: [PATCH] perf tools: Check for null when copying nsinfo. Hello, On Thu, Aug 09, 2018 at 11:53:48PM +0200, Benno Evers wrote: > The argument to nsinfo__copy() was assumed to be valid, but some code paths > exist that will lead to NULL being passed. > > In particular, running 'perf script -D' on a perf.data file containing an > PERF_RECORD_MMAP event associating the '[vdso]' dso with pid 0 earlier in > the event stream will lead to a segfault. > > Since all calling code is already checking for a non-null return value, > just return NULL for this case as well. Acked-by: Namhyung Kim <namhyung@...nel.org> It seems you missed the Signed-off-by though. Thanks, Namhyung > --- > tools/perf/util/namespaces.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/perf/util/namespaces.c b/tools/perf/util/namespaces.c > index 5be021701f34..cf8bd123cf73 100644 > --- a/tools/perf/util/namespaces.c > +++ b/tools/perf/util/namespaces.c > @@ -139,6 +139,9 @@ struct nsinfo *nsinfo__copy(struct nsinfo *nsi) > { > struct nsinfo *nnsi; > > + if (nsi == NULL) > + return NULL; > + > nnsi = calloc(1, sizeof(*nnsi)); > if (nnsi != NULL) { > nnsi->pid = nsi->pid; > -- > 2.17.1 >
Powered by blists - more mailing lists