lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 10 Aug 2018 08:35:58 +0200
From:   Maxime Jourdan <maxi.jourdan@...adoo.fr>
To:     Rob Herring <robh@...nel.org>
Cc:     Maxime Jourdan <maxi.jourdan@...adoo.fr>,
        Neil Armstrong <narmstrong@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic <linux-amlogic@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 4/4] drm/meson: convert to the new canvas module

2018-08-10 0:41 GMT+02:00 Rob Herring <robh@...nel.org>:
> Hi, this is an automated email from Rob's (experimental) review bot. I
> found a couple of common problems with your patch. Please see below.
>
> On Wed,  1 Aug 2018 20:51:28 +0200, Maxime Jourdan wrote:
>> This removes the meson_canvas files within the meson/drm layer
>> and makes use of the new canvas module that is referenced in the dts.
>>
>> Canvases can be used by different IPs and modules, and it is as such
>> preferable to rely on a module that can safely dispatch canvases on
>> demand.
>>
>> Signed-off-by: Maxime Jourdan <maxi.jourdan@...adoo.fr>
>
> The preferred subject prefix is "dt-bindings: <binding dir>: ...".
>
>> ---
>>  .../bindings/display/amlogic,meson-vpu.txt    |  9 +--
>>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi     |  7 +-
>>  drivers/gpu/drm/meson/Kconfig                 |  1 +
>>  drivers/gpu/drm/meson/Makefile                |  2 +-
>>  drivers/gpu/drm/meson/meson_canvas.c          | 70 -------------------
>>  drivers/gpu/drm/meson/meson_canvas.h          | 42 -----------
>>  drivers/gpu/drm/meson/meson_crtc.c            |  5 +-
>>  drivers/gpu/drm/meson/meson_drv.c             | 35 ++++++----
>>  drivers/gpu/drm/meson/meson_drv.h             |  5 +-
>>  drivers/gpu/drm/meson/meson_plane.c           |  3 +-
>>  drivers/gpu/drm/meson/meson_viu.c             |  1 -
>>  11 files changed, 39 insertions(+), 141 deletions(-)
>>  delete mode 100644 drivers/gpu/drm/meson/meson_canvas.c
>>  delete mode 100644 drivers/gpu/drm/meson/meson_canvas.h
>>
>
> DT bindings (including binding headers) should be a separate patch. See
> Documentation/devicetree/bindings/submitting-patches.txt.
>

Hi, What's the standard procedure here ? The reason I kept
devicetree+drm changes together is because I didn't want to have
floating commits that would break the drm module.

Should I split the changes anyway ?

Maxime

Powered by blists - more mailing lists