linux-kernel - Re: Problems with uio_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ac09d84-31bf-4d25-dba7-0a61effa2b04@redhat.com>
Date:   Sun, 12 Aug 2018 18:55:58 +0800
From:   Xiubo Li <xiubli@...hat.com>
To:     "Harris, James R" <james.r.harris@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "Walker, Benjamin" <benjamin.walker@...el.com>,
        "Wodkowski, PawelX" <pawelx.wodkowski@...el.com>
Subject: Re: Problems with uio_pci_generic in v4.18-rc8

Hi Harris,

Since the lock protection in uio irq handler is useless currently as 
discussed in the mail list, so I will revert this commit with small 
changes and now the testing based LIO/TCMU has been finished.

Thanks,
BRs


On 2018/8/11 5:12, Harris, James R wrote:
> Hi,
>   
> Using Linux kernel v4.18-rc8, I am unable to bind a PCI device to uio_pci_generic.  This works fine with v4.18-rc4.  dmesg shows:
>   
> [  336.221585] genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 33
> [  336.221681] uio_pci_generic: probe of 0000:04:00.0 failed with error -22
>   
> This problem has been reproduced on multiple systems.
>   
> This seems to be related to commit 9421e45f5 (“uio: use request_threaded_irq instead”) which was merged in -rc5.  Reverting this commit fixes the issue (I also reverted 543af5861f and 57c5f4df0a which also touch uio.c - just to be safe).
>   
> This seems like a serious regression to uio_pci_generic, but any tips or pointers would be appreciated.
>   
> Thanks,
>   
> Jim Harris
>