linux-kernel - Re: [PATCH] acpi: processor_throttling: fixed a few brace coding style issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2258817.rCk9hs2z3C@aspire.rjw.lan>
Date:   Sun, 12 Aug 2018 13:19:02 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     David Archuleta <darchuletajr@...il.com>
Cc:     lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acpi: processor_throttling: fixed a few brace coding style issues.

On Thursday, July 26, 2018 10:23:41 PM CEST David Archuleta wrote:
> From: darchuletajr <darchuletajr@...il.com>
> 
> Fixed a few brace coding style issues found by running
> ./scripts/checkpatch
> 
> Signed-off-by: David Archuleta Jr. <darchuletajr@...il.com>

IMO this doesn't add any value to the code, so I'm not going to apply it.

> ---
>  drivers/acpi/processor_throttling.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
> index fbc936cf2025..75cc179b352b 100644
> --- a/drivers/acpi/processor_throttling.c
> +++ b/drivers/acpi/processor_throttling.c
> @@ -298,9 +298,8 @@ static int acpi_processor_get_platform_limit(struct acpi_processor *pr)
>  
>  	status = acpi_evaluate_integer(pr->handle, "_TPC", NULL, &tpc);
>  	if (ACPI_FAILURE(status)) {
> -		if (status != AE_NOT_FOUND) {
> +		if (status != AE_NOT_FOUND)
>  			ACPI_EXCEPTION((AE_INFO, status, "Evaluating _TPC"));
> -		}
>  		return -ENODEV;
>  	}
>  
> @@ -431,9 +430,8 @@ static int acpi_processor_get_throttling_control(struct acpi_processor *pr)
>  
>  	status = acpi_evaluate_object(pr->handle, "_PTC", NULL, &buffer);
>  	if (ACPI_FAILURE(status)) {
> -		if (status != AE_NOT_FOUND) {
> +		if (status != AE_NOT_FOUND)
>  			ACPI_EXCEPTION((AE_INFO, status, "Evaluating _PTC"));
> -		}
>  		return -ENODEV;
>  	}
>  
> @@ -516,9 +514,8 @@ static int acpi_processor_get_throttling_states(struct acpi_processor *pr)
>  
>  	status = acpi_evaluate_object(pr->handle, "_TSS", NULL, &buffer);
>  	if (ACPI_FAILURE(status)) {
> -		if (status != AE_NOT_FOUND) {
> +		if (status != AE_NOT_FOUND)
>  			ACPI_EXCEPTION((AE_INFO, status, "Evaluating _TSS"));
> -		}
>  		return -ENODEV;
>  	}
>  
> @@ -596,9 +593,8 @@ static int acpi_processor_get_tsd(struct acpi_processor *pr)
>  
>  	status = acpi_evaluate_object(pr->handle, "_TSD", NULL, &buffer);
>  	if (ACPI_FAILURE(status)) {
> -		if (status != AE_NOT_FOUND) {
> +		if (status != AE_NOT_FOUND)
>  			ACPI_EXCEPTION((AE_INFO, status, "Evaluating _TSD"));
> -		}
>  		return -ENODEV;
>  	}
>  
>