linux-kernel - Re: [PATCH] arm64: dts: rockchip: Add idle-states to device tree for rk3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae312dc3-f640-ecf3-049a-c8576bb83330@rock-chips.com>
Date:   Mon, 13 Aug 2018 00:24:45 +0800
From:   Tao Huang <huangtao@...k-chips.com>
To:     Heiko Stuebner <heiko@...ech.de>, Caesar Wang <wxt@...k-chips.com>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>,
        Xing Zheng <zhengxing@...k-chips.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Catalin Marinas <catalin.marinas@....com>,
        dbasehore@...omium.org, Will Deacon <will.deacon@....com>,
        dianders@...omium.org, Rob Herring <robh+dt@...nel.org>,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        tony.xie@...k-chips.com, David Wu <david.wu@...k-chips.com>,
        cf@...k-chips.com, Jianqun Xu <jay.xu@...k-chips.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add idle-states to device tree for
 rk3399

Hi Heiko:

On 2018年08月10日 04:09, Heiko Stuebner wrote:
> Am Mittwoch, 6. Juli 2016, 10:20:54 CEST schrieb Caesar Wang:
>
>>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> index a6dd623..12ce265 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> @@ -101,6 +101,18 @@
>>  			};
>>  		};
>>  
>> +		idle-states {
>> +			entry-method = "psci";
>> +			cpu_sleep: cpu-sleep-0 {
>> +				compatible = "arm,idle-state";
>> +				local-timer-stop;
>> +				arm,psci-suspend-param = <0x0010000>;
>> +				entry-latency-us = <350>;
>> +				exit-latency-us = <600>;
>> +				min-residency-us = <1150>;
> Looking at the chromeos kernel, there are some more patches adapting
> this idle-state to use different timings.
Yes, we have another values. So the values of this patch are wrong.
>
> There also was a cluster-idle state added for a while but that seems to
> cause audio issues according to the CrOS history.

DMA or Audio driver should add PM_QOS_CPU_DMA_LATENCY or other methods to avoid the effects of idle.
Idle itself is good.

Thanks!