linux-kernel - Re: [PATCH] gcc-plugins: require GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQ2THEDLB8so3zahGykH_BWaWAU7Tg_2yGEPKo+ApsxHg@mail.gmail.com>
Date:   Mon, 13 Aug 2018 16:38:17 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Stefan Agner <stefan@...er.ch>, Kees Cook <keescook@...omium.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>, jbacik@...com,
        Emese Revfy <re.emese@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gcc-plugins: require GCC

2018-08-11 18:48 GMT+09:00 Stefan Agner <stefan@...er.ch>:
> Unsurprisingly GCC plugins require GCC as a compiler. This avoids
> GCC plugins being selectable when using clang.
>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
>  arch/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index 1aa59063f1fd..8c693a837ed7 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -422,7 +422,7 @@ config HAVE_GCC_PLUGINS
>
>  menuconfig GCC_PLUGINS
>         bool "GCC plugins"
> -       depends on HAVE_GCC_PLUGINS
> +       depends on HAVE_GCC_PLUGINS && CC_IS_GCC
>         depends on PLUGIN_HOSTCC != ""
>         help
>           GCC plugins are loadable modules that provide extra features to the
> --
> 2.18.0
>

I guess the more correct way is to fix
scripts/gcc-plugin.sh

This shell script should exit 0
only when GCC plugin is supported.

Kees?



-- 
Best Regards
Masahiro Yamada