linux-kernel - Re: [PATCH v8 04/22] s390/zcrypt: Integrate ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Aug 2018 11:34:27 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     Harald Freudenberger <freude@...ux.ibm.com>
Cc:     Tony Krowiak <akrowiak@...ux.vnet.ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, freude@...ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, borntraeger@...ibm.com,
        kwankhede@...dia.com, bjsdjshi@...ux.vnet.ibm.com,
        pbonzini@...hat.com, alex.williamson@...hat.com,
        pmorel@...ux.vnet.ibm.com, alifm@...ux.vnet.ibm.com,
        mjrosato@...ux.vnet.ibm.com, jjherne@...ux.vnet.ibm.com,
        thuth@...hat.com, pasic@...ux.vnet.ibm.com, berrange@...hat.com,
        fiuczy@...ux.vnet.ibm.com, buendgen@...ibm.com,
        frankja@...ux.ibm.com
Subject: Re: [PATCH v8 04/22] s390/zcrypt: Integrate ap_asm.h into
 include/asm/ap.h.

On Mon, 13 Aug 2018 11:24:48 +0200
Harald Freudenberger <freude@...ux.ibm.com> wrote:

> Here is now the add-on patch which changes the returncode for the
> ap_instructions_available() function.
> 
> I talked with Heiko Carstens and this patch will go into the next pull
> request for the 4.19 kernel.

I was just about to ask :)

> 
> -----------------------------------------------------------------------------------------
> From 9e050f843f3281da1f65292422e30f2dd1fd6d98 Mon Sep 17 00:00:00 2001
> From: Harald Freudenberger <freude@...ux.ibm.com>
> Date: Thu, 9 Aug 2018 11:59:34 +0200
> Subject: [PATCH] s390/zcrypt: fix ap_instructions_available() returncodes
> 
> During review of KVM patches it was complained that the
> ap_instructions_available() function returns 0 if AP
> instructions are available and -ENODEV if not. The function
> acts like a boolean function to check for AP instructions
> available and thus should return 0 on failure and != 0 on
> success. Changed to the suggested behaviour and adapted
> the one and only caller of this function which is the ap
> bus core code.
> 
> Signed-off-by: Harald Freudenberger <freude@...ux.ibm.com>
> ---
>  arch/s390/include/asm/ap.h   | 10 +++++-----
>  drivers/s390/crypto/ap_bus.c |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)

Looks sane to me.

Acked-by: Cornelia Huck <cohuck@...hat.com>