linux-kernel - Re: [PATCH] md/bcache: Remove NULL check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Aug 2018 18:00:11 +0800
From:   Coly Li <colyli@...e.de>
To:     Sean Fu <fxinrong@...il.com>
Cc:     kent.overstreet@...il.com, linux-bcache@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] md/bcache: Remove NULL check.

On 2018/8/13 5:38 PM, Sean Fu wrote:
> Remove unnessesary NULL check before kmem_cache_destroy() in
> drivers/md/bcache/request.c
> 
> Signed-off-by: Sean Fu <fxinrong@...il.com>

Hi Sean,

A same change is posted in my previous checkpatch fixes series. You may
find it from,
https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/?h=for-next

The identical patch is,
https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/commit/?h=for-next&id=26b39d0732955ecb839d0afe8d6211d70f213384

Thanks.

Coly Li

> ---
>  drivers/md/bcache/request.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index ae67f5f..0ddee35 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1306,8 +1306,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)
>  
>  void bch_request_exit(void)
>  {
> -	if (bch_search_cache)
> -		kmem_cache_destroy(bch_search_cache);
> +	kmem_cache_destroy(bch_search_cache);
>  }
>  
>  int __init bch_request_init(void)
>