linux-kernel - Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Aug 2018 15:25:54 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Gao Xiang <gaoxiang25@...wei.com>
Cc:     Chao Yu <chao@...nel.org>, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, Chao Yu <yuchao0@...wei.com>,
        linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] staging: erofs: add error handling for xattr
 submodule

On Mon, Aug 13, 2018 at 08:17:27PM +0800, Gao Xiang wrote:
> > 	/* we assume that ofs is aligned with 4 bytes */
> > 	it->ofs = EROFS_XATTR_ALIGN(it->ofs);
> > 	return err;
> > 

This might be cleaner if we wrote:

	return (err < 0) ? error : 0;

The callers all treate zero and one the same so there isn't any reason
to propogate the 1 back.

regards,
dan carpenter