linux-kernel - Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Aug 2018 10:11:51 -0500
From:   Suman Anna <s-anna@...com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
CC:     <linux-remoteproc@...r.kernel.org>, Sekhar Nori <nsekhar@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

Hi Bjorn,

On 07/23/2018 06:27 PM, Suman Anna wrote:
> The Davinci remoteproc driver does not support error recovery at
> present, so mark the corresponding remoteproc flag appropriately
> so that the debugfs flag shows the value as 'disabled' by default.
> 
> Signed-off-by: Suman Anna <s-anna@...com>

Can you pick up this minor patch for 4.19 please, I do not see this in
your rproc-next branch?

Thanks,
Suman

> ---
>  drivers/remoteproc/da8xx_remoteproc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index b668e32996e2..53160d5ed543 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -284,6 +284,9 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
>  		goto free_mem;
>  	}
>  
> +	/* error recovery is not supported at present */
> +	rproc->recovery_disabled = true;
> +
>  	drproc = rproc->priv;
>  	drproc->rproc = rproc;
>  	drproc->dsp_clk = dsp_clk;
>