linux-kernel - Re: [PATCH] irqchip/s3c24xx: Remove unneeded comparison of unsigned long to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35e59c4f-0f36-6a39-d075-dac32f75bce8@arm.com>
Date:   Mon, 13 Aug 2018 16:21:08 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip/s3c24xx: Remove unneeded comparison of unsigned
 long to 0

On 13/08/18 16:11, Krzysztof Kozlowski wrote:
> irq_data->hwirq is unsigned long.  This fixes GCC warning:
> 
>     drivers/irqchip/irq-s3c24xx.c: In function 's3c_irqext0_type':
>     drivers/irqchip/irq-s3c24xx.c:253:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
>       if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
>                        ^~
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/irqchip/irq-s3c24xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index f6fd57ebe6e6..c19766fe8a1a 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -250,7 +250,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned int type)
>  	void __iomem *gpcon_reg;
>  	unsigned long gpcon_offset, extint_offset;
>  
> -	if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
> +	if (data->hwirq <= 3) {
>  		gpcon_reg = S3C2410_GPFCON;
>  		extint_reg = S3C24XX_EXTINT0;
>  		gpcon_offset = (data->hwirq) * 2;
> 

Queued, thanks.

	M.
-- 
Jazz is not dead. It just smells funny...