linux-kernel - Re: [PATCH net-next 1/9] net: hns3: Add support for serdes loopback selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180813.085456.1905254242911513146.davem@davemloft.net>
Date:   Mon, 13 Aug 2018 08:54:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     salil.mehta@...wei.com
Cc:     yisen.zhuang@...wei.com, lipeng321@...wei.com,
        mehta.salil.lnk@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        linyunsheng@...wei.com
Subject: Re: [PATCH net-next 1/9] net: hns3: Add support for serdes
 loopback selftest

From: Salil Mehta <salil.mehta@...wei.com>
Date: Sun, 12 Aug 2018 10:47:30 +0100

> -#define HNS3_SELF_TEST_TPYE_NUM		1
> +#define HNS3_SELF_TEST_TPYE_NUM		2

Is this supposed to be the number of self test "types"?  If so, this CPP
macro should be named "HNS3_SELF_TEST_TYPE_NUM".

> +
> +		count ++;
                     ^

Please remove that unnecessary space.

> +	} while (++i < HCLGE_SERDES_RETRY_NUM  &&
                                             ^^

Only need one space there, not two.