linux-kernel - Re: [PATCH V5] thermal: Add cooling device's statistics in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18709513.zahsa7p5Fo@dimapc>
Date:   Mon, 13 Aug 2018 20:02:50 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH V5] thermal: Add cooling device's statistics in sysfs

On Monday, 13 August 2018 19:53:33 MSK Viresh Kumar wrote:
> On 13 August 2018 at 22:13, Dmitry Osipenko <digetx@...il.com> wrote:
> > On Monday, 13 August 2018 19:21:43 MSK Viresh Kumar wrote:
> >> On 13 August 2018 at 21:36, Dmitry Osipenko <digetx@...il.com> wrote:
> >> > I'm working on adding support of OPP and cooling for NVIDIA Tegra20/30
> >> > CPUFreq driver and stumbled upon a bug that is introduced by this
> >> > patch.
> >> > It is triggered on the driver module unload.
> >> 
> >> The problem is that device_unregister() will end up freeing the cdev as
> >> well, so the current sequence is surely wrong.
> >> 
> >> > diff --git a/drivers/thermal/thermal_core.c
> >> > b/drivers/thermal/thermal_core.c index 6ab982309e6a..de53c821a282
> >> > 100644
> >> > --- a/drivers/thermal/thermal_core.c
> >> > +++ b/drivers/thermal/thermal_core.c
> >> > @@ -1102,8 +1102,8 @@ void thermal_cooling_device_unregister(struct
> >> > thermal_cooling_device *cdev)>
> >> > 
> >> >         mutex_unlock(&thermal_list_lock);
> >> >         
> >> >         ida_simple_remove(&thermal_cdev_ida, cdev->id);
> >> > 
> >> > -       device_unregister(&cdev->device);
> >> > 
> >> >         thermal_cooling_device_destroy_sysfs(cdev);
> >> > 
> >> > +       device_unregister(&cdev->device);
> >> 
> >> But this looks wrong as well, as the device is still around while
> >> memory of its sysfs data is gone.
> > 
> > Indeed.
> > 
> >> Maybe something like this is what we need:
> >> 
> >> device_del();
> >> thermal_cooling_device_destroy_sysfs();
> >> device_put();
> > 
> > [I just realized that thermal_zone and cooling_device are not
> > interrelated.
> > I'm not familiar with the thermal/ code]
> > 
> > Thank you Viresh, your proposal looks good to me and works fine. Will you
> > make a proper patch?
> 
> Maybe you send a patch for this and take the credit as well :)

Okay, I'll make the patch. Thank you for the help.