linux-kernel - RE: [PATCH] Performance Improvement in CRC16 Calculations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN1PR04MB18246863506680B4ACB30866EA390@SN1PR04MB1824.namprd04.prod.outlook.com>
Date:   Mon, 13 Aug 2018 18:41:27 +0000
From:   Jeffrey Lien <Jeff.Lien@....com>
To:     Joe Perches <joe@...ches.com>,
        "dgilbert@...erlog.com" <dgilbert@...erlog.com>,
        Nicolas Pitre <nicolas.pitre@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "tim.c.chen@...ux.intel.com" <tim.c.chen@...ux.intel.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        David Darrington <david.darrington@....com>,
        Jeff Furlong <jeff.furlong@....com>
Subject: RE: [PATCH] Performance Improvement in CRC16 Calculations.

Joe, Doug, Nicolas,
The CONFIG patch change suggested by Joe and Doug makes sense to do.   I'll do some additional testing to verify the performance on my systems.   


Jeff Lien

-----Original Message-----
From: Joe Perches [mailto:joe@...ches.com] 
Sent: Saturday, August 11, 2018 10:06 AM
To: dgilbert@...erlog.com; Nicolas Pitre <nicolas.pitre@...aro.org>
Cc: Jeffrey Lien <Jeff.Lien@....com>; linux-kernel@...r.kernel.org; linux-crypto@...r.kernel.org; linux-block@...r.kernel.org; linux-scsi@...r.kernel.org; herbert@...dor.apana.org.au; tim.c.chen@...ux.intel.com; martin.petersen@...cle.com; David Darrington <david.darrington@....com>; Jeff Furlong <jeff.furlong@....com>
Subject: Re: [PATCH] Performance Improvement in CRC16 Calculations.

On Sat, 2018-08-11 at 02:04 -0700, Joe Perches wrote:
> On Fri, 2018-08-10 at 22:39 -0400, Douglas Gilbert wrote:
> > but below is a copy and paste of a table 27 from draft SBC-4 
> > revision 15 in chapter 4.22.4.4 on page 87.
> 
> The posted code returns the proper crc for each 
> CONFIG_CRYPTO_CRCT10DIF_TABLE_SIZE value from
> 1 to 5 for these arrays.

Jeff, could you please test the suggested patch with your comparison framework again with each CONFIG_CRYPTO_CRCT10DIF_TABLE_SIZE from 1 to 5?

I get on a very limited test framework here:
(runtime average of 10 runs)

1: 4.32
2: 1.86
3: 1.31
4: 1.05
5: 0.99