linux-kernel - Re: [PATCH] perf tools: arm-spe: Fix uninitialized record error variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Aug 2018 15:59:12 -0300
From:   Arnaldo Carvalho de Melo <acme@...hat.com>
To:     Kim Phillips <kim.phillips@....com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Dongjiu Geng <gengdongjiu@...wei.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: arm-spe: Fix uninitialized record error
 variable

Em Mon, Aug 13, 2018 at 03:55:11PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Aug 10, 2018 at 05:45:12PM -0500, Kim Phillips escreveu:
> > The auxtrace init variable 'err' was not being initialized, leading
> > perf to abort early in an SPE record command when there was no explicit
> > error, rather only based whatever memory contents were on the stack.
> > Initialize it explicitly on getting an SPE successfully, the same way
> > cs-etm does.
> > 
> > Signed-off-by: Kim Phillips <kim.phillips@....com>
> > ---
> > Hi Arnaldo, please apply to perf/urgent / stable series if at all
> > possible.  Thank you.
> 
> In such cases the best thing is to have a "Fixes: ..." so that this gets
> automatically picked by the stabe trees, I'll try to find out what was
> the patch that introduced this problem.

This one was easy, there is just one cset for this file prior to this
fix, so:

Fixes: ffd3d18c20b8 ("perf tools: Add ARM Statistical Profiling Extensions (SPE) support")

- Arnaldo