linux-kernel - Re: [PATCH v6 3/5] drm/nouveau: Fix deadlock with fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5eedf19a59f06a4c7055660dc85d6dc23964abe9.camel@redhat.com>
Date:   Mon, 13 Aug 2018 15:12:11 -0400
From:   Lyude Paul <lyude@...hat.com>
To:     Ilia Mirkin <imirkin@...m.mit.edu>
Cc:     nouveau <nouveau@...ts.freedesktop.org>,
        "# 3.9+" <stable@...r.kernel.org>, Lukas Wunner <lukas@...ner.de>,
        Karol Herbst <karolherbst@...il.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        David Airlie <airlied@...ux.ie>,
        Ville Syrjälä 
        <ville.syrjala@...ux.intel.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Thierry Reding <treding@...dia.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 3/5] drm/nouveau: Fix deadlock with fb_helper with
 async RPM requests

On Mon, 2018-08-13 at 15:11 -0400, Ilia Mirkin wrote:
> On Mon, Aug 13, 2018 at 3:07 PM, Lyude Paul <lyude@...hat.com> wrote:
> > +bool
> > +nouveau_fbcon_hotplugged_in_suspend(struct nouveau_fbdev *fbcon)
> > +{
> > +       bool hotplug;
> > +
> > +       if (!fbcon)
> > +               return false;
> > +
> > +       mutex_lock(&fbcon->hotplug_lock);
> > +       hotplug = fbcon->hotplug_waiting;
> > +       mutex_unlock(&fbcon->hotplug_lock);
> > +
> > +       return hotplug;
> > +}
> 
> I'm probably missing it, but where is this function used?
oh no you aren't, I thought I got rid of that function! will respin in just a
moment
-- 
Cheers,
	Lyude Paul