linux-kernel - Re: [PATCH] cpumask: provide a dummy cpumask_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1-GQr9PDVZ-qs0qH36TifUfrroiXcfOhRBe6e5k-+SZA@mail.gmail.com>
Date:   Tue, 14 Aug 2018 00:05:59 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     caraitto@...gle.com
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Willem de Bruijn <willemb@...gle.com>,
        David Miller <davem@...emloft.net>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Ingo Molnar <mingo@...nel.org>, rakib.mullick@...il.com,
        Amritha Nambiar <amritha.nambiar@...el.com>,
        mhkelley@...look.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpumask: provide a dummy cpumask_next_wrap

On Tue, Aug 14, 2018 at 12:02 AM Caleb Raitto <caraitto@...gle.com> wrote:
>
> On Mon, Aug 13, 2018 at 2:55 PM Arnd Bergmann <arnd@...db.de> wrote:
> >
> > The virtio_net driver has become the first one to call cpumask_next_wrap()
> > even if CONFIG_SMP is disabled, leading to a build error:
> >
> > drivers/net/virtio_net.c: In function 'virtnet_set_affinity':
> > drivers/net/virtio_net.c:1916:10: error: implicit declaration of function 'cpumask_next_wrap'; did you mean 'cpumask_next_and'? [-Werror=implicit-function-declaration]
> >     cpu = cpumask_next_wrap(cpu, cpu_online_mask,
> >
> > Add a stub function along the lines of cpumask_first(), cpumask_next() etc.
> > I'm not entirely sure what should be returned in this case, but at
> > least for virtio_net, anything should work.
>
> Sorry about the build break, I think this patch with a fix was already merged:
>
> cpumask: make cpumask_next_wrap available without smp
> https://patchwork.ozlabs.org/patch/956670/

Ok, that's also a better fix than mine I think.

Thanks,

        Arnd