linux-kernel - Re: [PATCH] Support mksh as /bin/sh.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLMr1+M7Xnt5HFi73fkhgh2YEwJyaPrFb0tQ2i8T0-i-Q@mail.gmail.com>
Date:   Mon, 13 Aug 2018 15:32:16 -0700
From:   Kees Cook <keescook@...omium.org>
To:     arekm@...en.pl
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kbuild <linux-kbuild@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Ulf Magnusson <ulfalizer@...il.com>,
        Nicholas Piggin <npiggin@...il.com>
Subject: Re: [PATCH] Support mksh as /bin/sh.

On Mon, Aug 13, 2018 at 3:14 AM,  <arekm@...en.pl> wrote:
> From: Arkadiusz Miśkiewicz <arekm@...en.pl>
>
> mksh needs space between ! and ( to work properly. Otherwise this
> happens:
>
> + make oldconfig
> scripts/kconfig/conf  --oldconfig Kconfig
> ./scripts/clang-version.sh[18]: COPYING: not found
> printf: ‘__clang_major__’: expected a numeric value
> printf: ‘__clang_minor__’: expected a numeric value
> printf: ‘__clang_patchlevel__’: expected a numeric value
> init/Kconfig:24:warning: 'CLANG_VERSION': number is invalid
>
> Signed-off-by: Arkadiusz Miśkiewicz <arekm@...en.pl>

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  scripts/clang-version.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/clang-version.sh b/scripts/clang-version.sh
> index dbf0a31eb111..e65fbc3079d4 100755
> --- a/scripts/clang-version.sh
> +++ b/scripts/clang-version.sh
> @@ -12,7 +12,7 @@
>
>  compiler="$*"
>
> -if !( $compiler --version | grep -q clang) ; then
> +if ! ( $compiler --version | grep -q clang) ; then
>         echo 0
>         exit 1
>  fi
> --
> 2.18.0
>



-- 
Kees Cook
Pixel Security