linux-kernel - Re: [PATCH 1/4] ARM: dts: exynos: Add missing used PMIC regulators on Exynos5422 Odroid boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANAwSgQBthsKMKBBnKBnCJdKwKOMm0XKRn5r=gnpdbC6Eu9=ag@mail.gmail.com>
Date:   Mon, 13 Aug 2018 12:07:02 +0530
From:   Anand Moon <linux.amoon@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kukjin Kim <kgene@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-samsung-soc@...r.kernel.org,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH 1/4] ARM: dts: exynos: Add missing used PMIC regulators on
 Exynos5422 Odroid boards

Hi Krzysztof,

On Sun, 12 Aug 2018 at 18:55, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 11 August 2018 at 08:39, Anand Moon <linux.amoon@...il.com> wrote:
> > Hi Krzysztof,
> >
> > These patches should also be ported to u-boot to enable PMIC.
> >
> > I was just looking into S2MPS11B data sheet
> > According to the 1.2 Key Features of  S2MPS11
> >
> > BUCK1, BUCK2, BUCK3, BUCK4, BUCK6 have (0.65 V to 1.6 V) min /max range.
> > BUCK5 have (0.65 V to 2.0 V) min /max range.
> > BUCK7 have (1.2 V to 1.5 V) min / max range.
> > BUCK8 have (1.8 V to 2.1 V) min / max range.
> > BUCK10 have (0.75 V to 1.4 V) min / max range.
> >
> > BUCKBOST9 (3.0 V to 3.75 V) min / max range.
> >
> > LDO1, LDO6, LDO11, LDO22, LDO23, LDO27, LDO35 (0.8 V to 2.375 V) min / max range
> >
> > LDO2, LDO3, LDO5, LDO7, LDO9, LDO10, LD012, LDO13, LDO14, LDO15,
> > LDO16, LDO17, LDO18, LDO19, LDO20, LD021, LDO24, LDO25, LDO26,
> > LDO28, LDO29, LDO30, LDO31, LDO32, LDO33, LDO34, LDO36, LDO37, LDO38
> > (0.8 V to 3.95 V) min / max range
> >
> > I am aware off we have configures the min/max range as per board schematics.
> > but each regulator support dynamic voltage scale and have different
> > turn on/off voltage and current rating.
> >
> > So why are we not setting the regulator-min-microvolt /
> > regulator-max-microvolt as per datasheets.
> > Please correct me if I am wrong.
>
> Which regulators are not configured as in datasheet?
>
> Best regards,
> Krzysztof

Almost all the regulator have some miss default match of min/max setting.
I have tried to adjust the setting on top your above patches.

I am attaching my patch diff for testing.
I have have perform some stress testing and found no issue at my end.

Best Regards
-Anand

Download attachment "regulator.patch" of type "application/octet-stream" (9039 bytes)