linux-kernel - Re: [Regression] usb: xhci: Add XHCI_TRUST_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180814110220.brkfyjbtibuwzunx@holly.lan>
Date:   Tue, 14 Aug 2018 12:02:20 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Joseph Salisbury <joseph.salisbury@...onical.com>
Cc:     ard.biesheuvel@...aro.org, mathias.nyman@...ux.intel.com,
        gregkh@...uxfoundation.org,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Regression] usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas
 uPD720201

On Fri, Aug 10, 2018 at 12:13:53PM -0400, Joseph Salisbury wrote:
> Hi Daniel,
> 
> A kernel bug report was opened against Ubuntu [0].  It was found the
> following patch introduced the regression:
> 
> da9970668948 ("usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201")

I can see nothing in http://pad.lv/1773704 that indicates a regression
in this patch. How could there be? The patch does not not alter the
behaviour of uPD720202 devices (pdev->device == 0x0015).

 
> The bug reporter claims there is a typo in the patch that caused the
> regression.  I built a test kernel with a change to the suspected typo
> and the bug reporter claims it resolved the regression.  My test kernel
> had the following change:
> 
> -                       pdev->device == 0x0014)
> +                       pdev->device == 0x0015)
> 
> I was hoping to get your feedback, since you are the patch author.  Do
> you think this is an actual typo, or maybe there really needs to be two
> quirks?

No, it is a not a typo (and the change above *does* introduce a regression
;-) ). From this git logs I believe that:

  0x0014 -> uPD720201
  0x0015 -> uPD720202


Daniel.