linux-kernel - Re: [PATCH] fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1808141609440.3371@hadrien>
Date:   Tue, 14 Aug 2018 16:10:26 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Mark Brown <broonie@...nel.org>
cc:     Julia Lawall <julia.lawall@...6.fr>,
        Wu Zhigang <zhigang.wu@...ux.intel.com>, kbuild-all@...org,
        sof-ci-monitor@...ists.intel.com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Rander Wang <rander.wang@...ux.intel.com>,
        Pan Xiuli <xiuli.pan@...ux.intel.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix ifnullfree.cocci warnings



On Tue, 14 Aug 2018, Mark Brown wrote:

> On Tue, Aug 14, 2018 at 12:57:57PM +0200, Julia Lawall wrote:
> > From: kbuild test robot <fengguang.wu@...el.com>
> >
> >  NULL check before some freeing functions is not needed.
> >
> >  Based on checkpatch warning
> >  "kfree(NULL) is safe this check is probably not required"
> >  and kfreeaddr.cocci by Julia Lawall.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > Fixes: 0099cc17a399 ("ASoC:topology:avoid error log and oops during topology free.")
>
> This doesn't apply against current code, please check and resend (the
> above commit isn't in my tree:
>
> $ git show 0099cc17a399
> fatal: ambiguous argument '0099cc17a399': unknown revision or path not in the working tree.

Sorry, I didn't keep the tree information.

julia