linux-kernel - Re: [PATCH] spi:fix IDR collision on systems with both fixed and dynamic SPI bus numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180814141859.GC5810@sirena.org.uk>
Date:   Tue, 14 Aug 2018 15:18:59 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Kirill Kapranov <kirill.kapranov@...pulab.co.il>
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        l.stach@...gutronix.de
Subject: Re: [PATCH] spi:fix IDR collision on systems with both fixed and
 dynamic SPI bus numbers

On Mon, Aug 13, 2018 at 07:48:10PM +0300, Kirill Kapranov wrote:
> On systems where some controllers get a dynamic ID assigned and some have
> a fixed number (e.g. from ACPI tables), the current implementation might
> run into an IDR collision: in case of a fixed bus number is gotten by a
> driver (but not marked busy in IDR tree) and a driver with dynamic bus
> number gets the same ID and predictably fails.

Is this something that's actually happened for you?

> +	} else {
> +	/* devices with a fixed bus num must check-in with the num */
> +		mutex_lock(&board_lock);

The indentation here is weird, the comment isn't aligned with the code
it's commenting on.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)