linux-kernel - Re: [PATCH] soc/tegra: pmc: fix child-node lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180814142454.GB21075@ulmo>
Date:   Tue, 14 Aug 2018 16:24:54 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mikko Perttunen <mperttunen@...dia.com>
Subject: Re: [PATCH] soc/tegra: pmc: fix child-node lookup

On Mon, Aug 13, 2018 at 04:33:17PM +0200, Johan Hovold wrote:
> Hi Thierry,
> 
> On Thu, Mar 22, 2018 at 03:24:32PM +0100, Thierry Reding wrote:
> > On Wed, Nov 15, 2017 at 10:44:58AM +0100, Johan Hovold wrote:
> > > Fix child-node lookup during probe, which ended up searching the whole
> > > device tree depth-first starting at the parent rather than just matching
> > > on its children.
> > > 
> > > To make things worse, the parent pmc node could end up being prematurely
> > > freed as of_find_node_by_name() drops a reference to its first argument.
> > > 
> > > Fixes: 3568df3d31d6 ("soc: tegra: Add thermal reset (thermtrip) support to PMC")
> > > Cc: stable <stable@...r.kernel.org>     # 4.0
> > > Cc: Mikko Perttunen <mperttunen@...dia.com>
> > > Signed-off-by: Johan Hovold <johan@...nel.org>
> > > ---
> > >  drivers/soc/tegra/pmc.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Applied, thanks.
> 
> I noticed this one still hasn't made it into linux-next. Looks like it
> wasn't included in you 4.17 pull request and is still sitting in the
> tegra for-4.17/soc branch.

Indeed. Looking at my tree it seems like I applied this to for-4.17/soc
a couple of days after the signed tag for the pull request. It probably
should've gone into a for-4.18/soc, or perhaps into fixes pull request.

I've cherry-picked it into for-4.20/soc now. Thanks for the reminder.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)