linux-kernel - Re: [PATCH v2 2/2] kgdboc: Change printk to the right fashion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180814144132.mpqzz3sxdbfzn7fe@holly.lan>
Date:   Tue, 14 Aug 2018 15:41:32 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Joe Perches <golf@...ches.com>
Cc:     zhe.he@...driver.com, jason.wessel@...driver.com,
        gregkh@...uxfoundation.org, jslaby@...e.com,
        kgdb-bugreport@...ts.sourceforge.net, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] kgdboc: Change printk to the right fashion

On Tue, Aug 14, 2018 at 07:04:11AM -0700, Joe Perches wrote:
> On Tue, 2018-08-14 at 14:35 +0100, Daniel Thompson wrote:
> > On Tue, Aug 14, 2018 at 08:46:01PM +0800, zhe.he@...driver.com wrote:
> > > From: He Zhe <zhe.he@...driver.com>
> > > 
> > > pr_* is preferred according to scripts/checkpatch.pl.
> []
> > > diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c
> []
> > > @@ -136,7 +136,7 @@ static int kgdboc_option_setup(char *opt)
> > >  	}
> > >  
> > >  	if (strlen(opt) >= MAX_CONFIG_LEN) {
> > > -		printk(KERN_ERR "kgdboc: config string too long\n");
> > > +		pr_err("kgdboc: config string too long\n");
> > 
> > Looks like you should remove the tags from pr_err and use pr_fmt(fmt) to
> > put tags on the messages:
> > 
> > #define pr_fmt(fmt) "kgdboc: " fmt
> 
> True and it's probably better to use:
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Good point! Thanks.


Daniel.