linux-kernel - Re: [PATCH 1/5] block: genhd: add 'groups' argument to device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <712eaa404a1a76193b1a304443dcbae339e53ab5.camel@wdc.com>
Date:   Tue, 14 Aug 2018 15:17:11 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "hare@...e.de" <hare@...e.de>, "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "martin.wilck@...e.com" <martin.wilck@...e.com>,
        "sagi@...mberg.me" <sagi@...mberg.me>, "hch@....de" <hch@....de>,
        "hare@...e.com" <hare@...e.com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "keith.busch@...el.com" <keith.busch@...el.com>
Subject: Re: [PATCH 1/5] block: genhd: add 'groups' argument to
 device_add_disk

On Tue, 2018-08-14 at 09:33 +0200, Hannes Reinecke wrote:
> Update device_add_disk() to take an 'groups' argument so that
> individual drivers can register a device with additional sysfs
> attributes.
> This avoids race condition the driver would otherwise have if these
             ^ "a" is missing?
> groups were to be created with sysfs_add_groups().

Anyway:

Reviewed-by: Bart Van Assche <bart.vanassche@....com>