lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Aug 2018 07:18:05 +0300 From: Baruch Siach <baruch@...s.co.il> To: zhong jiang <zhongjiang@...wei.com> Cc: a.zummo@...ertech.it, alexandre.belloni@...tlin.com, linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code Hi zhong, On Mon, Aug 13, 2018 at 07:31:24PM +0800, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang <zhongjiang@...wei.com> Acked-by: Baruch Siach <baruch@...s.co.il> Thanks, baruch > --- > drivers/rtc/rtc-digicolor.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c > index b253bf1..fd6850c 100644 > --- a/drivers/rtc/rtc-digicolor.c > +++ b/drivers/rtc/rtc-digicolor.c > @@ -202,10 +202,8 @@ static int __init dc_rtc_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, rtc); > rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name, > &dc_rtc_ops, THIS_MODULE); > - if (IS_ERR(rtc->rtc_dev)) > - return PTR_ERR(rtc->rtc_dev); > > - return 0; > + return PTR_ERR_OR_ZERO(rtc->rtc_dev); > } > > static const struct of_device_id dc_dt_ids[] = { -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Powered by blists - more mailing lists