linux-kernel - [PATCH 4.14 025/104] x86/irqflags: Provide a declaration for native_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180814171516.850387480@linuxfoundation.org>
Date:   Tue, 14 Aug 2018 19:16:39 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, David Laight <david.laight@...lab.com>,
        Jean Delvare <jdelvare@...e.de>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>, hpa@...or.com,
        jgross@...e.com, kstewart@...uxfoundation.org,
        boris.ostrovsky@...cle.com, astrachan@...gle.com, mka@...omium.org,
        arnd@...db.de, tstellar@...hat.com, sedat.dilek@...il.com,
        David.Laight@...lab.com
Subject: [PATCH 4.14 025/104] x86/irqflags: Provide a declaration for native_save_fl

4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Nick Desaulniers <ndesaulniers@...gle.com>

commit 208cbb32558907f68b3b2a081ca2337ac3744794 upstream.

It was reported that the commit d0a8d9378d16 is causing users of gcc < 4.9
to observe -Werror=missing-prototypes errors.

Indeed, it seems that:
extern inline unsigned long native_save_fl(void) { return 0; }

compiled with -Werror=missing-prototypes produces this warning in gcc <
4.9, but not gcc >= 4.9.

Fixes: d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline").
Reported-by: David Laight <david.laight@...lab.com>
Reported-by: Jean Delvare <jdelvare@...e.de>
Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: hpa@...or.com
Cc: jgross@...e.com
Cc: kstewart@...uxfoundation.org
Cc: gregkh@...uxfoundation.org
Cc: boris.ostrovsky@...cle.com
Cc: astrachan@...gle.com
Cc: mka@...omium.org
Cc: arnd@...db.de
Cc: tstellar@...hat.com
Cc: sedat.dilek@...il.com
Cc: David.Laight@...lab.com
Cc: stable@...r.kernel.org
Link: https://lkml.kernel.org/r/20180803170550.164688-1-ndesaulniers@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 arch/x86/include/asm/irqflags.h |    2 ++
 1 file changed, 2 insertions(+)

--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -13,6 +13,8 @@
  * Interrupt control:
  */

+/* Declaration required for gcc < 4.9 to prevent -Werror=missing-prototypes */
+extern inline unsigned long native_save_fl(void);
 extern inline unsigned long native_save_fl(void)
 {
 	unsigned long flags;