linux-kernel - Re: [PATCH 6/9] platform: goldfish: pipe: Fail compilation if structs are too large

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5899fe3c616db608d45303e9ac4563df6546333.camel@perches.com>
Date:   Mon, 13 Aug 2018 21:41:06 -0700
From:   Joe Perches <joe@...ches.com>
To:     Roman Kiryanov <rkir@...gle.com>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        Todd Kjos <tkjos@...gle.com>
Subject: Re: [PATCH 6/9] platform: goldfish: pipe: Fail compilation if
 structs are too large

On Mon, 2018-08-13 at 20:47 -0700, Roman Kiryanov wrote:
> Hi,
> 
> thank you for reviewing my patches. I decided to put BUILD_BUG_ON
> close to places where it is important that these structs fit into a
> memory page to give some context.

And you make the reader figure out what type dev->buffers is
unnecessarily when sizeof(struct goldfish_pipe_dev_buffers)
is pretty obvious.

> Regards,
> Roman.

cheers, Joe