linux-kernel - Re: [PATCH] f2fs: rework fault injection handling to avoid a warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bee2baa8-1768-4e80-9f63-baf52d6359b9@huawei.com>
Date:   Tue, 14 Aug 2018 14:05:52 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Arnd Bergmann <arnd@...db.de>, Jaegeuk Kim <jaegeuk@...nel.org>
CC:     Yunlei He <heyunlei@...wei.com>,
        Sheng Yong <shengyong1@...wei.com>,
        <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] f2fs: rework fault injection handling to avoid a warning

On 2018/8/14 5:38, Arnd Bergmann wrote:
> When CONFIG_F2FS_FAULT_INJECTION is disabled, we get a warning about an
> unused label:
> 
> fs/f2fs/segment.c: In function '__submit_discard_cmd':
> fs/f2fs/segment.c:1059:1: error: label 'submit' defined but not used [-Werror=unused-label]
> 
> This could be fixed by adding another #ifdef around it, but the more
> reliable way of doing this seems to be to remove the other #ifdefs
> where that is easily possible.
> 
> By defining time_to_inject() as a trivial stub, most of the checks for
> CONFIG_F2FS_FAULT_INJECTION can go away. This also leads to nicer
> formatting of the code.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,