linux-kernel - Re: [PATCH] dt-bindings: phy: qcom-qmp: Cleanup the 'reg' documentation as per review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180814201234.GA22842@rob-hp-laptop>
Date:   Tue, 14 Aug 2018 14:12:34 -0600
From:   Rob Herring <robh@...nel.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Douglas Anderson <dianders@...omium.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Manu Gautam <mgautam@...eaurora.org>,
        Mark Rutland <mark.rutland@....com>,
        Varadarajan Narayanan <varada@...eaurora.org>
Subject: Re: [PATCH] dt-bindings: phy: qcom-qmp: Cleanup the 'reg'
 documentation as per review

On Mon,  6 Aug 2018 22:14:12 -0700, Douglas Anderson <dianders@...omium.org> wrote:
> After the commit 8b1087fa3a27 ("phy: qcom-qmp: Fix dts bindings to
> reflect reality") landed there was some review feedback that 'reg'
> should have been documented differently.  Fix it as per review
> feedback.
> 
> As per that feedback:
> - Subject should have been 'dt-bindings: phy:' which this patch now
>   has.
> - We should leave no ambiguity in the ordering of 'reg' ranges even if
>   'reg-names' are also specified.
> - Normally using reg-names is discouraged unless there's a strong
>   reason it's needed (like if there are optional ranges).  In this
>   case reg-names wasn't needed but the driver already landed relying
>   on reg-names so we'll just document it and move on.
> 
> Fixes: 8b1087fa3a27 ("phy: qcom-qmp: Fix dts bindings to reflect reality")
> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> 
>  .../devicetree/bindings/phy/qcom-qmp-phy.txt  | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>