linux-kernel - Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Veu9+vQPjq+1uWnaocobcHUBpkHKx6OfKW3-E_UeVtKfA@mail.gmail.com>
Date:   Wed, 15 Aug 2018 12:45:07 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Chris Chiu <chiu@...lessm.com>
Cc:     Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
        Hans de Goede <hdegoede@...hat.com>,
        Linux Upstreaming Team <linux@...lessm.com>
Subject: Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on
 kbd brightness change

On Wed, Aug 15, 2018 at 12:34 PM, Chris Chiu <chiu@...lessm.com> wrote:
> On Mon, Jul 2, 2018 at 8:10 PM, Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
>> On Wed, Jun 27, 2018 at 1:27 PM, Chris Chiu <chiu@...lessm.com> wrote:
>>> On Wed, Jun 20, 2018 at 10:46 PM, Chris Chiu <chiu@...lessm.com> wrote:
>>>> Make asus-wmi notify on hotkey kbd brightness changes, listen for
>>>> brightness events and update the brightness directly in the driver.
>>>> Create new do_kbd_led_set function for in-driver update, and leave
>>>> kbd_led_set for original led_classdev call path.
>>>>
>>>> Update the brightness by led_classdev_notify_brightness_hw_changed.
>>>> This will allow userspace to monitor (poll) for brightness changes
>>>> on the LED without reporting via input keymapping.
>>
>> LGTM, I'm about to push it to my review and testing queue, so, we will
>> have 1 day or so time to gather objections if any.
>> Thanks!
>>
>
> Gentle ping. How's the review so far? Maybe need more time for more info?

Sorry, I thought we have no objections and I pushed it to our for-next
quite time ago [1].
Should I do something differently?

[1]: http://git.infradead.org/linux-platform-drivers-x86.git/commitdiff/dbb3d78f61badeadc7448f9d88a070a76612860f

-- 
With Best Regards,
Andy Shevchenko