linux-kernel - [PATCH] statfs: fix potential Spectre v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180815133608.GA27979@embeddedor.com>
Date:   Wed, 15 Aug 2018 08:36:08 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Alexander Viro <viro@...iv.linux.org.uk>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: [PATCH] statfs: fix potential Spectre v1

user_params.request is indirectly controlled by user-space, hence leading
to a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

fs/statfs.c:908 __do_sys_fsinfo() warn: potential spectre issue
'fsinfo_buffer_sizes' [r]

Fix this by sanitizing user_params.request before using it to index
fsinfo_buffer_sizes

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2

Cc: stable@...r.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
---
 fs/statfs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/statfs.c b/fs/statfs.c
index f714f05..d74a60a 100644
--- a/fs/statfs.c
+++ b/fs/statfs.c
@@ -11,6 +11,7 @@
 #include <linux/compat.h>
 #include <linux/fsinfo.h>
 #include <linux/fs_parser.h>
+#include <linux/nospec.h>
 #include "internal.h"
 
 static int flags_by_mnt(int mnt_flags)
@@ -886,6 +887,8 @@ SYSCALL_DEFINE5(fsinfo,
 			return -EINVAL;
 		if (user_params.request >= FSINFO_ATTR__NR)
 			return -EOPNOTSUPP;
+		user_params.request = array_index_nospec(user_params.request,
+							 FSINFO_ATTR__NR);
 		params.at_flags = user_params.at_flags;
 		params.request = user_params.request;
 		params.Nth = user_params.Nth;
-- 
2.7.4