linux-kernel - Re: [PATCH 4.9 000/107] 4.9.120-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Aug 2018 20:22:16 +0200
From:   Sebastian Gottschall <s.gottschall@...wrt.com>
To:     Sven Joachim <svenjoac@....de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, ben.hutchings@...ethink.co.uk,
        lkft-triage@...ts.linaro.org, stable@...r.kernel.org
Subject: Re: [PATCH 4.9 000/107] 4.9.120-stable review


Am 15.08.2018 um 19:52 schrieb Sven Joachim:
> On 2018-08-15 19:01 +0200, Sebastian Gottschall wrote:
>
>> nother issue seen on xscale and as it affects all non SMP configured kernels
>>
>>
>> kernel/cpu.c: In function 'boot_cpu_hotplug_init':
>> kernel/cpu.c:2204:28: error: 'struct cpuhp_cpu_state' has no member
>> named 'booted_once'
>>    this_cpu_write(cpuhp_state.booted_once, true);
> I got a different error in 4.9.120 with CONFIG_SMP unset:

that doesnt make it better :-) i havend checked x86 without smp, just 
xscale. your error doesnt affect xscale which is a arm platform. all 
these issues seem to affect 4.14 as well

btw. i found another compile error with x86 :-)


arch/x86/kernel/apic/apic.c:2050:6: error: redefinition of 
'apic_id_is_primary_thread'
  bool apic_id_is_primary_thread(unsigned int apicid)
       ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./arch/x86/include/asm/smp.h:12,
                  from ./arch/x86/include/asm/tlbflush.h:10,
                  from ./arch/x86/include/asm/highmem.h:26,
                  from ./include/linux/highmem.h:34,
                  from ./include/linux/pagemap.h:10,
                  from ./arch/x86/include/asm/pgalloc.h:6,
                  from arch/x86/kernel/apic/apic.c:43:
./arch/x86/include/asm/apic.h:641:20: note: previous definition of 
'apic_id_is_primary_thread' was here
  static inline bool apic_id_is_primary_thread(unsigned int id) { return 
false; }



Sebastian

>
> ,----
> | CC      drivers/rtc/rtc-cmos.o
> | In file included from drivers/rtc/rtc-cmos.c:45:0:
> | ./arch/x86/include/asm/i8259.h: In function 'inb_pic':
> | ./arch/x86/include/asm/i8259.h:32:24: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
> |   unsigned char value = inb(port);
> |                         ^~~
> | ./arch/x86/include/asm/i8259.h: In function 'outb_pic':
> | ./arch/x86/include/asm/i8259.h:45:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
> |   outb(value, port);
> |   ^~~~
> | In file included from ./include/linux/mc146818rtc.h:14:0,
> |                  from drivers/rtc/rtc-cmos.c:49:
> | ./arch/x86/include/asm/io.h: At top level:
> | ./arch/x86/include/asm/io.h:277:20: warning: conflicting types for 'outb'
> |  static inline void out##bwl(unsigned type value, int port)  \
> |                     ^
> | ./arch/x86/include/asm/io.h:316:1: note: in expansion of macro 'BUILDIO'
> |  BUILDIO(b, b, char)
> |  ^~~~~~~
> | ./arch/x86/include/asm/io.h:277:20: error: static declaration of 'outb' follows non-static declaration
> |  static inline void out##bwl(unsigned type value, int port)  \
> |                     ^
> | ./arch/x86/include/asm/io.h:316:1: note: in expansion of macro 'BUILDIO'
> |  BUILDIO(b, b, char)
> |  ^~~~~~~
> | In file included from drivers/rtc/rtc-cmos.c:45:0:
> | ./arch/x86/include/asm/i8259.h:45:2: note: previous implicit declaration of 'outb' was here
> |   outb(value, port);
> |   ^~~~
> | In file included from ./include/linux/mc146818rtc.h:14:0,
> |                  from drivers/rtc/rtc-cmos.c:49:
> | ./arch/x86/include/asm/io.h:283:29: error: conflicting types for 'inb'
> |  static inline unsigned type in##bwl(int port)    \
> |                              ^
> | ./arch/x86/include/asm/io.h:316:1: note: in expansion of macro 'BUILDIO'
> |  BUILDIO(b, b, char)
> |  ^~~~~~~
> | In file included from drivers/rtc/rtc-cmos.c:45:0:
> | ./arch/x86/include/asm/i8259.h:32:24: note: previous implicit declaration of 'inb' was here
> |   unsigned char value = inb(port);
> `----
>
> Cheers,
>         Sven
>