linux-kernel - Re: [PATCH v3 1/2] dt-bindings: i2c: npcm7xx: add binding for i2c controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180815203015.GA19242@rob-hp-laptop>
Date:   Wed, 15 Aug 2018 14:30:15 -0600
From:   Rob Herring <robh@...nel.org>
To:     Tali Perry <tali.perry1@...il.com>
Cc:     avifishman70@...il.com, tmaimon77@...il.com, venture@...gle.com,
        yuenn@...gle.com, brendanhiggins@...gle.com, mark.rutland@....com,
        davem@...emloft.net, mchehab+samsung@...nel.org,
        gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        arnd@...db.de, wsa@...-dreams.de,
        andriy.shevchenko@...ux.intel.com, pierre-yves.mordret@...com,
        cedric.madianga@...il.com, baolin.wang@...eadtrum.com,
        jarkko.nikula@...ux.intel.com, hdegoede@...hat.com,
        rmk+kernel@...linux.org.uk, ard.biesheuvel@...aro.org,
        thor.thayer@...ux.intel.com, geert@...ux-m68k.org,
        heikki.krogerus@...ux.intel.com, tglx@...utronix.de,
        linux-i2c@...r.kernel.org, openbmc@...ts.ozlabs.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: npcm7xx: add binding for i2c
 controller

On Tue, Aug 14, 2018 at 09:29:06PM +0300, Tali Perry wrote:
> 
> Nuvoton NPCM7XX I2C Controller
> NPCM7xx includes 16 I2C contollers. This driver operates the controller.

s/contollers/controllers/

> This module also includes a slave mode, which will be submitted later on.
> 
> Any feedback would be appreciated.  
> 
> v3 -> v2:
> 	- fix dt binding: compatible name: ommit "bus"
> 
> v2 -> v1:
> 	- run check patch in strict mode.
> 	- use linux crc.
> 	- define regs in constant offset without base.
> 	- remove debug prints.
> 	- no declerations for local functions.
> 	
> v1: initial version

The version info normally goes below the '---' so it is not part of the 
commit msg.

> 
> Signed-off-by: Tali Perry <tali.perry1@...il.com>
> 
> ---
>  .../devicetree/bindings/i2c/i2c-npcm7xx.txt        | 29 ++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt b/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt
> new file mode 100644
> index 000000000000..2a474a2a5b3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt
> @@ -0,0 +1,29 @@
> +Nuvoton NPCM7XX I2C bus
> +
> +The NPCM750x includes sixteen I2C bus controllers. All Conterollers support

s/Conterollers/controllers/

With those fixed,

Reviewed-by: Rob Herring <robh@...nel.org>

> +both master and slave mode. Each controller has two 16 byte HW FIFO for TX and
> +RX.
> +
> +Required properties:
> +- compatible      : must be "nuvoton,npcm750-i2c"
> +- reg             : Offset and length of the register set for the device.
> +- interrupts      : Contain the I2C interrupt with flags for falling edge.
> +- clocks          : phandle of I2C reference clock.
> +
> +Optional:
> +- bus-frequency   : Contain the I2C bus frequency,
> +			the default I2C bus frequency is 100000.
> +- pinctrl-0       : must be <&smbX_pins>, X is module number
> +			(on NPCM7XX it's 0 to 15)
> +- pinctrl-names   : should be set to "default"
> +Example:
> +
> +	i2c0: i2c@...00 {
> +		compatible = "nuvoton,npcm750-i2c";
> +		reg = <0x80000 0x1000>;
> +		clocks = <&clk NPCM7XX_CLK_APB2>;
> +		bus-frequency = <100000>;
> +		interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&smb0_pins>;
> +	};
> -- 
> 2.14.1
>