linux-kernel - Re: [PATCH 2/2] [FIXED] Replace magic for trusting the secondary keyring with #define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFw1oaRiqAU_61BwqS5QWS2VtZ6o9cAF3YEVx2NfMkmHpQ@mail.gmail.com>
Date:   Wed, 15 Aug 2018 15:01:26 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     yannik@...britzki.me
Cc:     kbuild test robot <lkp@...el.com>, kbuild-all@...org,
        David Howells <dhowells@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Peter Anvin <hpa@...or.com>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dave Young <dyoung@...hat.com>, Baoquan He <bhe@...hat.com>,
        Justin Forbes <jforbes@...hat.com>,
        Peter Jones <pjones@...hat.com>,
        James Bottomley <James.Bottomley@...senpartnership.com>,
        Matthew Garrett <mjg59@...gle.com>,
        Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH 2/2] [FIXED] Replace magic for trusting the secondary
 keyring with #define

On Wed, Aug 15, 2018 at 2:19 PM Yannik Sembritzki <yannik@...britzki.me> wrote:
>
>
> +// Allow both builtin trusted keys and secondary trusted keys
> +#ifndef TRUST_SECONDARY_KEYRING
> +#define TRUST_SECONDARY_KEYRING ((struct key *)1UL)
> +#endif
>
> Sorry, I've fixed this now.

Actually, just remove the ifndef/endif entirely. There is no possible
other valid #define this could have, and the header itself is
protected from multi-inclusion the standard way.

                 Linus