linux-kernel - Re: [PATCH] x86/speculation/l1tf: Add assembly guard for xtensa/ia64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180815223658.GA11323@roeck-us.net>
Date:   Wed, 15 Aug 2018 15:36:58 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] x86/speculation/l1tf: Add assembly guard for xtensa/ia64

On Wed, Aug 15, 2018 at 02:56:46PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> The stable backport of the
> 
> x86/speculation/l1tf: Disallow non privileged high MMIO PROT_NONE mappings
> 
> patch for 4.4 and 4.9 put new C code for !__HAVE_ARCH_PFN_MODIFY_ALLOWED
> code outside the assembler ifdef. This breaks the xtensa and ia64
> build as reported by 0day which somehow include this file
> into assembler.
> 
> Just add an #ifdef __ASSEMBLY__ around the new code to fix this.
> 
> This patch is only needed for 4.9 and 4.4 stable, the newer stables
> don't have this problem.
> 
> Fixes: 7c5b42f82c13 ("x86/speculation/l1tf: Disallow non privileged high MMIO PROT_NONE mappings")
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

This should be fixed in the final stable releases.
The problem was caused by a couple of missing backports.

Guenter