[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180816101351.GB19047@w540>
Date: Thu, 16 Aug 2018 12:13:51 +0200
From: jacopo mondi <jacopo@...ndi.org>
To: Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
ldv-project@...uxtesting.org
Subject: Re: [PATCH] media: ov772x: Disable clk on error path
Hello Alexey,
thanks for the patch
On Wed, Aug 15, 2018 at 11:10:39PM +0300, Alexey Khoroshilov wrote:
> If ov772x_power_on() is unable to get GPIO rstb,
> the clock is left undisabled.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
Acked-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
Thanks
j
> ---
> drivers/media/i2c/ov772x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> index e2550708abc8..7b62bf1fc5b1 100644
> --- a/drivers/media/i2c/ov772x.c
> +++ b/drivers/media/i2c/ov772x.c
> @@ -828,6 +828,7 @@ static int ov772x_power_on(struct ov772x_priv *priv)
> GPIOD_OUT_LOW);
> if (IS_ERR(priv->rstb_gpio)) {
> dev_info(&client->dev, "Unable to get GPIO \"rstb\"");
> + clk_disable_unprepare(priv->clk);
> return PTR_ERR(priv->rstb_gpio);
> }
>
> --
> 2.7.4
>
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)
Powered by blists - more mailing lists