linux-kernel - Re: [GIT PULL] sound updates for 4.19-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb8d7d867726b934650ed20ceb4fe0d2a6a4f0f9.camel@perches.com>
Date:   Wed, 15 Aug 2018 19:05:25 -0700
From:   Joe Perches <joe@...ches.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Takashi Iwai <tiwai@...e.de>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] sound updates for 4.19-rc1

On Wed, 2018-08-15 at 19:00 -0700, Linus Torvalds wrote:
> On Wed, Aug 15, 2018 at 6:27 PM Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> > 
> > I have no idea _why_, but it's consistent, and it bisects down to
> > 
> >   c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
> > 
> > where the previous commit works fine, but that commit definitely
> > causes the problem.
> 
> Hmm.
> 
> That commit changes the return value of the
> snd_hda_gen_add_micmute_led(), but doesn't change any of the callers.
> 
> Now, almost no caller actually checks the return value.
> 
> Almost.
> 
> There is *one* caller that does, though:
> 
> sound/pci/hda/dell_wmi_helper.c:
>   alc_fixup_dell_wmi()
> 
> And yes, the laptop that breaks is a Dell. An XPS13.
> 
> I bet that instead of reverting, I can just change that
> 
>                         (snd_hda_gen_add_micmute_led(codec,
>                                                      dell_micmute_update) <= 0);
> 
> to test for "< 0" instead of "<= 0".

Why does the commit change snd_hda_gen_add_micmute_led
to return 0; instead of return 1;

That bit looks wrong.