linux-kernel - Re: [PATCH] kdb: kdb_main: refactor code in kdb_md

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47366683-621e-6efa-91d5-69ac93a9af37@embeddedor.com>
Date:   Thu, 16 Aug 2018 08:47:07 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     Jason Wessel <jason.wessel@...driver.com>,
        kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kdb: kdb_main: refactor code in kdb_md_line



On 8/16/18 4:32 AM, Daniel Thompson wrote:

>> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
>> index 2ddfce8..4b896a6 100644
>> --- a/kernel/debug/kdb/kdb_main.c
>> +++ b/kernel/debug/kdb/kdb_main.c
>> @@ -1538,25 +1538,9 @@ static void kdb_md_line(const char *fmtstr, unsigned long addr,
>>  			wc.word = word;
>>  #define printable_char(c) \
>>  	({unsigned char __c = c; isascii(__c) && isprint(__c) ? __c : '.'; })
>> -			switch (bytesperword) {
>> -			case 8:
>> +			for (i = 0; i < bytesperword; i++)
> 
> i already a control variable for the outer loop. It is not safe to reuse
> it here.
> 

Oh I see. I'll send v2 shortly.

Thanks
--
Gustavo