linux-kernel - Re: [PATCH 1/2] coresight: etb10: Refactor etb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cd6b8a8-2370-517d-deb1-378bff6e362b@arm.com>
Date:   Thu, 16 Aug 2018 16:13:03 +0100
From:   Suzuki K Poulose <Suzuki.Poulose@....com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        linux-arm-kernel@...ts.infradead.org
Cc:     alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] coresight: etb10: Refactor etb_drvdata::mode handling

Hi Mathieu,

The patch looks good to me. One minor nit below.

On 14/08/18 23:14, Mathieu Poirier wrote:
> This patch moves the etb_drvdata::mode from a locat_t to a simple u32,
> as it is for the ETF and ETR drivers.  This streamlines the code and adds
> commonality with the other drivers when dealing with similar operations.
> 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> ---
>   drivers/hwtracing/coresight/coresight-etb10.c | 62 +++++++++++++++------------
>   1 file changed, 34 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
> index 9fd77fdc1244..69287163ce4e 100644
> --- a/drivers/hwtracing/coresight/coresight-etb10.c
> +++ b/drivers/hwtracing/coresight/coresight-etb10.c

> @@ -488,7 +494,7 @@ static void etb_dump(struct etb_drvdata *drvdata)
>   	unsigned long flags;
>   
>   	spin_lock_irqsave(&drvdata->spinlock, flags);
> -	if (local_read(&drvdata->mode) == CS_MODE_SYSFS) {
> +	if (drvdata->mode == CS_MODE_SYSFS) {
>   		etb_disable_hw(drvdata);
>   		etb_dump_hw(drvdata);
>   		etb_enable_hw(drvdata);

Looks good to me.

Reviewed-by : Suzuki K Poulose <suzuki.poulose@....com>