linux-kernel - Re: [linux-next] Kernel panic while tetsing criu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180816172154.GA28188@outlook.office365.com>
Date:   Thu, 16 Aug 2018 10:21:55 -0700
From:   Andrey Vagin <avagin@...tuozzo.com>
To:     Cyrill Gorcunov <gorcunov@...il.com>
Cc:     "Eric W. Biederman" <ebiederm@...ssion.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [linux-next] Kernel panic while tetsing criu

On Thu, Aug 16, 2018 at 06:18:35PM +0300, Cyrill Gorcunov wrote:
> On Thu, Aug 16, 2018 at 09:51:36AM -0500, Eric W. Biederman wrote:
> ...
> > 
> > That patch is incorrect as it misses the rcu_read_unlock.
> > >
> > > p.s. Andrew noticed the problem and asked me to notify,
> > > also he has been testing this oneliner patch. I'm out
> > > of sources at the moment but I think Andrew will help
> > > to test if needed.
> > 
> > I noticed a similar report from syzbot yesterday and I applied the patch
> > below.  Can you verify it fixes your issue?
> 
> I'm quite sure it will help, since the patch is almost doing the same
> as Andrew's fast fix, which checks for @p being nil. But to be sure
> lets wait Andrew to verify.

It fixes the issue.

Thanks,
Andrei